os_string fixes for cross-compilation and Android when Swift is enabled #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linux was hardcoded, now we use OS_STRING generated in configure.ac. Also, the build_cpu instead of the host_cpu was used for swiftmoddir, resulting in an incorrect destination directory.
MadCoder
approved these changes
Jan 2, 2017
das
pushed a commit
that referenced
this pull request
Feb 21, 2017
os_string fixes for cross-compilation and Android when Swift is enabled Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two different issues were affecting the use and generation of output directories for libraries.
androidfor thelinux-androideabitarget OSTo fix the latter, I'm now passing
OS_STRINGand usinghost_cpuinstead ofbuild_cpu.